Stop sending me huge PRs; a rant

#Stop #Article #Comments #Points

Article URL: https://getsmall.xyz/post/cmstjfl9l000if70ljmpzr4va Comments URL: https://news.ycombinator.com/item?id=49305558 Points: 20 # Comments: 4

Stop sending me huge PRs; a rant

I'm tired boss. I'm tired of reviewing one, two, three thousand line PRs because some agent was able to "one shot the whole issue." Small PRs were never asked for because they're easier to write, it's always been for the benefit of the reviewer. AI is such a boon to the industry, but it's becoming such a liability for reviewers and maintainers. Maybe I'm just an old man yelling at the clouds, but please, stop sending me huge PRs.

I have heard on multiple occasions recently the argument that "it won't work without the whole change" or "the code will do nothing if we don't put in the entire diff," well, yeah? Good? The point of small PRs is not necessarily to have small, individual, finished products. It's to have small, digestable, reviewable, understandable pieces of work. I have no data for this, so I will wildly speculate, that the time it takes to fully comprehend a piece of code increases exponentially with the number of lines the code covers. Taking up exponentially more of my time because you wanted to ship a full feature does not spark joy.

While we're at it, I don't need 50 line comments. Sure, document functions, give me jsdoc, rustdoc, javadoc, all of that good stuff. Absolutely do not give me 5 lines of comments on why a variable is named is_logged_in. If your variable is named well, 9 times out of 10 I'll understand what it does. If your variable is not named well and you need a comment, name your variable better.

Похожие статьи

Hacker News
Hacker News

Abdominal fat predicts heart disease risk better than BMI

Article URL: https://www.acc.org/about-acc/press-releases/2026/08/11/14/59/abdominal-fat-predicts-heart-disease-risk-better-than-bmi Comments URL: https://news.ycombinator.com/item?id=49314403 Points:...

Hacker News
The Verge
The Verge

Matt Groening lets slip that Simpsons: Hit & Run might be making a comeback

At D23, when asked about the potential for a sequel to the cult classic The Simpsons: Hit & Run game, Matt Groening replied, "I think the original game is coming back in some form," before current sho...

The Verge
Hacker News
Hacker News

Bede Liu, a digital signal processing pioneer, has died

Article URL: https://spectrum.ieee.org/digital-signal-processing Comments URL: https://news.ycombinator.com/item?id=49314615 Points: 14 # Comments: 0

Hacker News
Hacker News
Hacker News

The Wow signal was a strong narrowband radio signal detected on August 15, 1977

Article URL: https://en.wikipedia.org/wiki/Wow!_signal Comments URL: https://news.ycombinator.com/item?id=49314596 Points: 13 # Comments: 1

Hacker News
TechCrunch
TechCrunch

Woman claims her stepfather used Grok to transform childhood photo into explicit imagery

The woman claimed that AI tools are "taking everyday life and turning it into child sexual abuse."

TechCrunch
VisionQuest trailer kicks off Disney's D23 fan event Ars Technica
Ars Technica

VisionQuest trailer kicks off Disney's D23 fan event

Also: Ahsoka S2 teaser, Doomsday trailer, news about MCU's X-Men and Star Wars: Starfighter

Ars Technica